From 364763e039b286774c29c4995df6baba9d22a61a Mon Sep 17 00:00:00 2001 From: WriterV2 Date: Sun, 24 Nov 2024 12:17:32 +0100 Subject: Perf: Avoid unnecessary heap allocations of strings --- src/handlers/admin.rs | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'src/handlers/admin.rs') diff --git a/src/handlers/admin.rs b/src/handlers/admin.rs index 3d16b32..6cc79c2 100644 --- a/src/handlers/admin.rs +++ b/src/handlers/admin.rs @@ -76,14 +76,13 @@ pub async fn upload_story( } let name = if let Some(name_value) = form.get("name") { - String::from_utf8(name_value.to_vec()).with_context(|| "Failed to parse name")? + std::str::from_utf8(name_value).with_context(|| "Failed to parse name")? } else { return Ok(StatusCode::BAD_REQUEST.into_response()); }; let description = if let Some(description_value) = form.get("description") { - String::from_utf8(description_value.to_vec()) - .with_context(|| "Failed to parse description")? + std::str::from_utf8(description_value).with_context(|| "Failed to parse description")? } else { return Ok(StatusCode::BAD_REQUEST.into_response()); }; @@ -95,7 +94,7 @@ pub async fn upload_story( }; let pdf = if let Some(pdf_value) = form.get("pdf") { - let filename = format_filepath(&name, "pdf"); + let filename = format_filepath(name, "pdf"); let file = std::fs::File::create_new(filename)?; BufWriter::new(file).write_all(pdf_value)?; pdf_value.to_vec() @@ -104,7 +103,7 @@ pub async fn upload_story( }; let epub = if let Some(epub_value) = form.get("epub") { - let filename = format_filepath(&name, "epub"); + let filename = format_filepath(name, "epub"); let file = std::fs::File::create_new(filename)?; BufWriter::new(file).write_all(epub_value)?; epub_value.to_vec() @@ -112,10 +111,11 @@ pub async fn upload_story( return Ok(StatusCode::BAD_REQUEST.into_response()); }; - let mut tags: Vec = Vec::new(); + let mut tags: Vec<&str> = Vec::new(); if let Some(tags_value) = form.get("tag") { - for tag in String::from_utf8(tags_value.to_vec())?.split(",") { - tags.push(tag.trim().to_string()); + let tagstring = std::str::from_utf8(tags_value)?; + for tag in tagstring.split(",") { + tags.push(tag.trim()); } } -- cgit v1.2.3